Avoid use of instanceof #1625
Merged
Avoid use of instanceof #1625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instanceof causes issues in nightly because VSIX version and test version of the PackageNode class are different Also allow passing folder context to package commands as are some random focus issues
award999
added
the
full-test-run
matthewbastien
approved these changes
Jun 18, 2025
rbenegal
approved these changes
Jun 18, 2025
matthewbastien
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instanceof causes issues in nightly because VSIX version and test version of the PackageNode class are different
Also allow passing folder context to package commands as are some random focus issues